Title: Issues with Makefile in circom-circuit Directory
Issue Description
Summary:
Encountered multiple issues with the Makefile in the circom-circuit directory of the myna-wallet-monorepo. These issues hinder the initialization process and affect the proper execution of make commands.
Problems Identified:
Directory Creation Failure: The init command in the Makefile fails if the directories already exist. The command mkdir ./setup && mkdir ./build leads to an error if either of these directories is present, halting the initialization process.
Powers of Tau File Download URL Potential Mismatch: The current URL used in the curl command within the init target fetching powersOfTau28_hez_final_19.ptau but after steps uses powersOfTau28_hez_final_20.ptau. It looks the intended version of the Powers of Tau file misconfigured.
Incorrect Powers of Tau File Path: In the gov-sig-build-circuit and user-sig-build-circuit targets, the file path to the Powers of Tau file appears to be outdated or incorrect. This issue could lead to problems in circuit compilation and verification due to the use of an incorrect version of the Powers of Tau file.
Suggested Solutions:
For the directory creation issue, updating the mkdir command to use the -p flag could prevent the error when directories already exist.
The Powers of Tau file paths and download URLs in the make targets should be verified and updated to ensure they are correct and up-to-date.
Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report
Issue 1
go to myna-wallet-monorepo/packages/circom-circuit
run make init
run make init again
Issue2
go to myna-wallet-monorepo/packages/circom-circuit
run make init
Issue3
go to myna-wallet-monorepo/packages/circom-circuit
run make init
run make gov-sig-build-circuit
run make gov-sig-setup-groth16
or
go to myna-wallet-monorepo/packages/circom-circuit
What command(s) is the bug in?
make init
Describe the bug
Title: Issues with
Makefileincircom-circuitDirectoryIssue Description
Summary:
Encountered multiple issues with the
Makefilein thecircom-circuitdirectory of themyna-wallet-monorepo. These issues hinder the initialization process and affect the proper execution of make commands.Problems Identified:
Directory Creation Failure: The
initcommand in theMakefilefails if the directories already exist. The commandmkdir ./setup && mkdir ./buildleads to an error if either of these directories is present, halting the initialization process.Error message received:
Powers of Tau File Download URL Potential Mismatch: The current URL used in the curl command within the
inittarget fetching powersOfTau28_hez_final_19.ptau but after steps uses powersOfTau28_hez_final_20.ptau. It looks the intended version of the Powers of Tau file misconfigured.Incorrect Powers of Tau File Path: In the
gov-sig-build-circuitanduser-sig-build-circuittargets, the file path to the Powers of Tau file appears to be outdated or incorrect. This issue could lead to problems in circuit compilation and verification due to the use of an incorrect version of the Powers of Tau file.Suggested Solutions:
mkdircommand to use the-pflag could prevent the error when directories already exist.Concrete steps to reproduce the bug. If it's able reproduce via testool, please share
test_idfrom jenkins reportIssue 1
Issue2
Issue3