search

MyoHub / myosuite

MyoSuite is a collection of environments/tasks to be solved by musculoskeletal models simulated with the MuJoCo physics engine and wrapped in the OpenAI gym API.
https://sites.google.com/view/myosuite
Apache License 2.0
858 stars 112 forks source link

Incorrect thumb joints nomenclature #112

Open andreh1111 opened 1 year ago

andreh1111 commented 1 year ago

Hi, I think the myoHand nomenclature related to the thumb joints (cmc_abduction, cmc_flexion, mp_flexion, ipflexion) isn't correct for two reasons: 1) for all the other fingers, the word after "" is what happens toward the maximum value of qpos (e.g., when mcp2_flexion is max, the index finger is flexed) while the thumb joints are extended when _flexion is max. The same logic is for _abduction. 2) cmc_abduction and cmc_flexion are reversed.

Vittorio-Caggiano commented 1 year ago

Hi @andreh1111 thanks for pointing to this issue. We will update the hand model after the MyoChallenge.