search

MyreMylar / pygame_gui

A GUI system for pygame.
MIT License
684 stars 78 forks source link

Merge auto scrolling container with scrolling container #575

Closed MyreMylar closed 5 months ago

MyreMylar commented 5 months ago

Since there wasn't that much code left in the auto scrolling container anyway it seems easier just to merge this functionality into the base container and turn it on by default with a parameter to control turning it off as is needed.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.25%. Comparing base (371b0f1) to head (67384e1).

Files Patch % Lines
pygame_gui/elements/ui_scrolling_container.py 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #575 +/- ## ========================================== - Coverage 96.26% 96.25% -0.01% ========================================== Files 89 89 Lines 13156 13153 -3 ========================================== - Hits 12665 12661 -4 - Misses 491 492 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MyreMylar commented 5 months ago

will do this simple functionality merge for now - for the UIForm PR and further testing - but will likely swap it over in there and then remove it entirely.