Error when open and incomplete header partition pack

[francescoBLT]

Hi I found that when there is an open and incomplete header partition pack, program reports a wrong headerbytecount in footer, either if the value is correct. This is due to the fact that IsHeaderByteCountCorrect method evaluate value measuring from start of primer pack to end of partition, but doesn't take account of index table present on footer. Correct value should be from start of primer pack to index table offset, as reported from MXFAnalyzer Lite from IRT. I correct the bug on my code, how can I get in touch with contributors ? Regards FrancescoBLT

[rayden84]

Hello and thanks for reporting the issue! I am one of the contributors and I was not sure if MXFInspect should also consider the index tables for the header bytes calculation. I think you have two options: 1) If you are familiar with git and github just make a pull request and I will integrate your correction into this repo 2) Otherwise just post the corrected code here

Thank you

[francescoBLT]

I made a pull request, due to the fact that I'm noto very proficient with git, can you check ?
regards

[rayden84]

Hello, unfortunately I don't see any pull request on this repository. What did you do? For a PR usually you have to fork this repo, make the changes and then commit. Afterwards you can push your changes to your forked repo which is hosted at github. From there just click the Compare & pull request button: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request#creating-the-pull-request

Otherwise there's always the option to post the code here. Let me know if you need further help.