search

Myrroddin / repbyzone

World of Warcraft AddOn that switches your watched faction by the player's zone
https://www.curseforge.com/wow/addons/repbyzone
3 stars 2 forks source link

Deprecated APIs with patch 11.0.0 #10

Closed lucasvienna closed 2 months ago

lucasvienna commented 2 months ago

While the TOC was bumped to the latest version, the deprecated APIs are still in use:

1x RepByZone/Core-Retail.lua:663: attempt to call upvalue 'GetFactionInfoByID' (a nil value)
[string "@RepByZone/Core-Retail.lua"]:663: in function <RepByZone/Core-Retail.lua:660>

Locals:
(*temporary) = nil
(*temporary) = 2510
(*temporary) = "attempt to call upvalue 'GetFactionInfoByID' (a nil value)"
watchedFactionID = 2510
factionName = nil
_ = nil
isWatched = nil
GetFactionInfoByID = nil
C_Reputation = <table> {}

I tried quickly replacing them with the newer C_Reputation.GetFactionDataByID, but it quickly turned into more than just search and replace, so I thought best to open an issue.

Myrroddin commented 2 months ago

You are correct, this is more than fixing a line or two with an updated API. Blizzard changed lots of things. I'm working on it.

Myrroddin commented 2 months ago

Fixed with version 1.34.17