search

Mystcraft / Mystcraft-Legacy

Mystcraft 1, open sourced. Mystcraft Legacy is focused on extending the add-on support, mod compatibility, and usability of the original Mystcraft.
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Project Workspace Setup Processes Documentation #3

Open XCompWiz opened 7 months ago

XCompWiz commented 7 months ago

Minecraft Version(s)

All

Request

Currently it is unclear how to get the project working locally. Even I don't remember all of it. We need documentation.

I've started a branch for 1.7.10 (1.7.10/feature/readme) with a README file. I wasn't able to get the project to build successfully in the few minutes I had to do this. Someone will need to investigate further. I suspect we need a JDK within a specific range to be installed.

We'll need to do the same process for the other major development branches as well.

Pilzinsel64 commented 6 months ago

For 1.7.10, see: #4 The mod builds and runs fine as far as I can tell.

XCompWiz commented 6 months ago

For 1.7.10, see: #4 The mod builds and runs fine as far as I can tell.

I'd like to get everything working with the way it was working before prior to making any significant changes. In this case, that means getting the gradle commands running as is.

Pilzinsel64 commented 6 months ago

I'd like to get everything working with the way it was working before ... getting the gradle commands running as is.

That's then up to you if it's ok. I just don't know gradle build configuration good enough for that.

But as far as I know the most commands should work like before. Like gradlew build, gradlew runClient, gradlew setupDecompWorkspace or gradlew setupCIWorkspace.

As for the "fixes" in https://github.com/Mystcraft/Mystcraft-Legacy/pull/4/commits/fa87e809530004686e6c1cf1942c2c4a19d1d722 and https://github.com/Mystcraft/Mystcraft-Legacy/pull/4/commits/f11b73ef0fc96355d979688ea833a8d37f677151 my Java 8 JDK might be too new then and does not support things that did work in the past probably. I have installed OpenJDK 8.0.372.7.

XCompWiz commented 6 months ago

Hypothetically, all that needs to happen is we look up / determine the correct version of JDK to use when working with that version of Forge. No gradle config should need to happen, I believe.

Pilzinsel64 commented 6 months ago

The java version for the used gradlew wrapper is 1.7.0_02. So maybe it's just enough to use the most recent JDK 7 (but didn't tested it).