search

Mystcraft / Mystcraft-Legacy

Mystcraft 1, open sourced. Mystcraft Legacy is focused on extending the add-on support, mod compatibility, and usability of the original Mystcraft.
GNU Lesser General Public License v3.0
10 stars 3 forks source link

[1.12.2] Issue with GUI backgrounds #7

Open xJon opened 6 months ago

xJon commented 6 months ago

Usually when opening a GUI (e.g. the Crafting Table), the background behind it is darkened: image

When opening the GUI of any of Mystcraft's blocks (Link Modifier, Ink Mixer, Book Binder, Writing Desk), the background behind it is not darkened, which looks out of place (especially with JEI installed): image

ACGaming commented 6 months ago

Missing either a drawDefaultBackground() or a drawGuiContainerBackgroundLayer() call in GUI rendering.

XCompWiz commented 6 months ago

Mystcraft uses a very custom GUI rendering system (which greatly simplified element construction and reuse). Chances are that line or the equivalent of it can be added to the base screen class of Mystcraft's GUIs. Probably, that background used to be rendered before the GUIs and then got moved into something Mystcraft had replaced, and I didn't notice.

Nice catch!