search

Mystcraft / Mystcraft-Legacy

Mystcraft 1, open sourced. Mystcraft Legacy is focused on extending the add-on support, mod compatibility, and usability of the original Mystcraft.
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Move rendering to wrapped methods #8

Open kadir1243 opened 6 months ago

kadir1243 commented 6 months ago

Seems like some pieces of rendering uses extension and direct Gl calls, For Example DynamicLinkPanelRenderer and ShaderUtils use ARBShaderObjects extension, ARBShaderObjects extension should not be used and usages should be replaced by OpenGlHelper for example ModelRendererAdvanced uses direct gl calls also seems like some parts of rendering (for example DniColorRenderer) still uses glBegin and glEnd instead of tessellator I don't know is this a bug or feature

XCompWiz commented 6 months ago

If it causes problems to not fix, it's a bug. If fixing it will improve performance or results in some way, it's a feature.

If neither, it's a "refactor", and mainly valuable to improve code quality (maintainability and readability).

XCompWiz commented 6 months ago

Are you able to provide a reference for how this should be done, and why doing it is an improvement?