Closed asonnino closed 1 year ago
I think we can merge with two nits:
(1) Can we remove the authority
field from the committer?
Comment says that it helps with debugging, but in fact this information should already be present in the debug log?
If you enable RUST_LOG in the simulator, you can actually see the node that outputs each line in the beginning of the log line:
[F] +03140 DEBUG mysticeti_core::consensus::base_committer: [BaseCommitter(v5, L0,R0)] Trying to commit ( wave: 8, leader_round: 24, last committed round: 22 )
([F] is the node)
(2) I think some of the code (like initializing old committer in core.rs) is commented out, can we delete commented out code? (git history have everything in case it is ever needed)
(2) I think some of the code (like initializing old committer in core.rs) is commented out, can we delete commented out code? (git history have everything in case it is ever needed)
yes I need to cleanup a couple of things before landing (and ideally adding one test)
[F] +03140 DEBUG mysticeti_core::consensus::base_committer: [BaseCommitter(v5, L0,R0)] Trying to commit ( wave: 8, leader_round: 24, last committed round: 22 ) ([F] is the node)
Nice I missed that
Enable pipeline mysticeti by default. The pipelined committer is already implemented and tested (through unit-tests), but the core still runs with the old (baseline) comitter.
This PR modifies the core to run the pipelined committer but it seems it makes the simulator tests unsatable. They seem slower than before and they sometimes trigger the following error: