MystenLabs / mysticeti

Mysticeti: Low-Latency DAG Consensus with Fast Commit Path
Apache License 2.0
55 stars 28 forks source link

A few updates to CommittedSubDag #38

Closed lxfind closed 1 year ago

lxfind commented 1 year ago

Needed by Sui.

lxfind commented 1 year ago

The Hash type is from fastcrypto, so we won't be able to implement it in Sui

andll commented 1 year ago

I also noticed that literally only place where we use the digest is info log in the consensus handler("Received consensus output..."). So instead of implementing Hash, should we just add Display trait on the ConsensusOutputAPI?

E.g. instead of ConsensusOutputAPI: Hash<DIGEST_SIZE>, we could do ConsensusOutputAPI: Display.

lxfind commented 1 year ago

Implemented Display instead