search

MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.23k stars 11.2k forks source link

filter issue when pass FromOrToAddress #14301

Open avaghasiya-supra opened 1 year ago

avaghasiya-supra commented 1 year ago

Steps to Reproduce Issue

[Error: Error checking transaction input objects: Unsupported("Some(FromOrToAddress { addr: 0x })")]

const client = new SuiClient({
      url: 'https://fullnode.devnet.sui.io:443/',
    });
const fromTransactionBlocks = await suiProvider.queryTransactionBlocks({
          filter: {
            FromOrToAddress: { addr: walletAddress },
          },
          options: {
            showInput: true,
          },
        });

Expected Result

we are not getting a response as expected.

System Information

stefan-mysten commented 1 year ago

@hayes-mysten do you maybe have a thought of what might have gone wrong here?

hayes-mysten commented 1 year ago

It looks like this is not implemented/supported by the full node API, the error comes from here: https://github.com/MystenLabs/sui/blob/main/crates/sui-storage/src/indexes.rs#L669-L693 but is part of the RPC spec. We re-use the same TransactionFilter type in multiple places, but not all the methods that accept that filter implement the all the filter options

hayes-mysten commented 1 year ago

This Filter is a work in-progress and isn't available on fullnodes yet, but it's being worked on and should be available soon

avaghasiya-supra commented 1 year ago

by when we expect it?

avaghasiya-supra commented 9 months ago

any update?

kecson commented 8 months ago

when support that filter?

DzmitryTurko commented 6 months ago

@hayes-mysten what do mean by soon ?)

hayes-mysten commented 6 months ago

@DzmitryTurko I just checked with the team working on this, and it sounds like this filter will not be added to the fullnode version of the JSON RPC API. It is not available in the GraphQL API yet, but it will be added there as well in the future

avaghasiya-supra commented 4 months ago

Hello @hayes-mysten any update?

hayes-mysten commented 4 months ago

Unfortunately not, The GraphQL team has been very focused on working through performance issues, and hasn't had time to prioritize this feature yet. I don't work on this myself, but this is a known blocker for people wanting to migrate to GraphQL, and is definitely still on their road map

phips28 commented 2 days ago

any updates? @hayes-mysten