MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
5.84k stars 11.06k forks source link

explicitly setup test scenario for test_query_default_page_limit #18393

Closed wlmyng closed 4 days ago

wlmyng commented 4 days ago

Description

Unblock https://github.com/MystenLabs/sui/pull/18277 by explicitly setting up the correct test scenario for the test_query_default_page_limit test.

I think we can follow this up with

  1. instead of using the same db url, follow sui-graphql-e2e-tests pattern and generate unique db urls for each test
  2. this is so that we can run tests in parallel instead of sequentially (which is the case today due to the serial)
  3. we can leverage ExecutorCluster.cleanup_resources to cleanup each test

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **multisig-toolkit** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/multisig-toolkit/8DFdHkREe4y11DGKkfptq1pxnKtK)) | | | Jun 24, 2024 11:32pm | | **sui-kiosk** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-kiosk/BaHGnzyDusNQtSRkoSNs5YMk5Z5j)) | | | Jun 24, 2024 11:32pm | | **sui-typescript-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-typescript-docs/7FueMXSCWzcYt85fiAJ1SqyhP3Sf)) | | | Jun 24, 2024 11:32pm |