MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.26k stars 11.21k forks source link

ExecutionCancelledDueToSharedObjectCongestion #19887

Closed wowok-ai closed 1 month ago

wowok-ai commented 1 month ago

https://testnet.suivision.xyz/txblock/3gwkhNH8deHPVBsagv7fvssC1QgtUH2AGXUT1MXgMEAS

This error did not occur when executing this transaction before. What is happening?

mwtian commented 1 month ago

I think the recommendation would be to use a more accurate gas budget (0.0021 instead of 0.0217264). Right now the system is unnecessarily treating this transaction as an expensive transaction that cannot be executed.

mystenmark commented 1 month ago

Hi - unfortunately we had to adjust our congestion control mechanism due to the current FOMO mining which is using large PTBs to stuff lots of work into a single transaction.

Any transaction that either has a budget of less than 0.018 SUI (18.5M MIST), or that has few enough MoveCalls / inputs will be able to run. "Few enough" means: sum of MoveCall commands + MoveCall Input object arguments < 46

Based on analyzing past checkpoints we did not find very many transactions that would be impacted by this, although we knew there would be a few, and we apologize.

The good news is that this is a temporary mitigation - in the next release we will add support for larger / higher budget transactions to run unimpeded once again.

Programmierus commented 1 month ago

You guys know, right, that under "not very many" fall indeed quite a few transactions that exchange aggregators produce with longer routes?

Impact example can be seen here.

mwtian commented 1 month ago

@Programmierus yes we are aware of the issue and sorry for the problems this has caused. An new protocol upgrade targeting tomorrow is in the works to raise the limit to avoid affecting these transactions.

mwtian commented 1 month ago

This should have been fixed now.