MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.27k stars 11.21k forks source link

Error in the wallet connect #20292

Open blacdav opened 1 week ago

blacdav commented 1 week ago

Screenshot (115)

  1. After setting up my project with NEXT.js 15, i noticed first that i couldn'nt wrap the wallet provider directly in the layout file, since the layout was for server side, and the walletProvider is a client component. i know the team is working hard, but please, can we make the walletProvider support serverside, this would be a great advantage, as alot of libraries and framework now supports both server side and clientside rendering.

  2. Also i noticed this error after when i tried to connect wallet using the 'ConnectWallet' button that's being Provided: Error: An empty string ("") was passed to the src attribute. This may cause the browser to download the whole page again over the network. To fix this, either do not render the element at all or pass null to src instead of an empty string. at createUnhandledError (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/react-dev-overlay/internal/helpers/console-error.js:23:19) at handleClientError (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/react-dev-overlay/internal/helpers/use-error-handler.js:41:56) at console.error (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/globals/intercept-console-error.js:53:56) at setProp (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:16850:25) at setInitialProperties (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:17402:21) at completeWork (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:13737:18) at runWithFiberInDEV (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:544:16) at completeUnitOfWork (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15102:19) at performUnitOfWork (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15005:11) at workLoopSync (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:14818:41) at renderRootSync (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:14796:11) at performWorkOnRoot (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:14290:11) at performSyncWorkOnRoot (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15859:7) at flushSyncWorkAcrossRoots_impl (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15721:21) at processRootScheduleInMicrotask (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15755:7) at eval (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-dom/cjs/react-dom-client.development.js:15875:13)

turns out that an empty string ("") is being passed to an src attribute somewhere in your application. This might happen when a resource (like an image or iframe) expects a valid URL but is being passed an empty value instead.

Please can someone look into this issue, Thank you.

Thetzx20 commented 1 week ago

How to solve this?

blacdav commented 1 week ago

I solved the first, but couldn't solve the second.

hayes-mysten commented 1 week ago

Can you provide any more details?

I have not been able to reproduce this. It is possible this is related to one of the wallet extensions you have installed. Does this still happen when all extensions are disabled?

Based on the error alone, there isn't a whole lot I can tell about what might be causing this. dapp-kit itself shouldn't be injecting any script tags as far as I am aware

hayes-mysten commented 1 week ago

Found 1 potential issue that could happen if you have a wallet with an incorrectly configured icon, but not sure that its related: https://github.com/MystenLabs/sui/pull/20304/files

Thetzx20 commented 5 days ago

Is it normal when I use keyboard and using autofoll it's asking for my passwords?

On Tue, Nov 19, 2024, 2:29 AM hayes-mysten @.***> wrote:

Found 1 potential issue that could happen if you have a wallet with an incorrectly configured icon, but not sure that its related: https://github.com/MystenLabs/sui/pull/20304/files

— Reply to this email directly, view it on GitHub https://github.com/MystenLabs/sui/issues/20292#issuecomment-2483812239, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMOPFOY7Y62DP2BRIOWVCET2BIWYBAVCNFSM6AAAAABR4KP6ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTHAYTEMRTHE . You are receiving this because you commented.Message ID: @.***>

Thetzx20 commented 5 days ago

Too many apps don't know who to trust and how do I know when somebody is hacking my account?

On Wed, Nov 20, 2024, 11:36 AM Life Line @.***> wrote:

Is it normal when I use keyboard and using autofoll it's asking for my passwords?

On Tue, Nov 19, 2024, 2:29 AM hayes-mysten @.***> wrote:

Found 1 potential issue that could happen if you have a wallet with an incorrectly configured icon, but not sure that its related: https://github.com/MystenLabs/sui/pull/20304/files

— Reply to this email directly, view it on GitHub https://github.com/MystenLabs/sui/issues/20292#issuecomment-2483812239, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMOPFOY7Y62DP2BRIOWVCET2BIWYBAVCNFSM6AAAAABR4KP6ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTHAYTEMRTHE . You are receiving this because you commented.Message ID: @.***>

Thetzx20 commented 5 days ago

I'm new to all of this so I'm getting a headstart should I sign out from everything and start a new?pls help

On Wed, Nov 20, 2024, 11:37 AM Life Line @.***> wrote:

Too many apps don't know who to trust and how do I know when somebody is hacking my account?

On Wed, Nov 20, 2024, 11:36 AM Life Line @.***> wrote:

Is it normal when I use keyboard and using autofoll it's asking for my passwords?

On Tue, Nov 19, 2024, 2:29 AM hayes-mysten @.***> wrote:

Found 1 potential issue that could happen if you have a wallet with an incorrectly configured icon, but not sure that its related: https://github.com/MystenLabs/sui/pull/20304/files

— Reply to this email directly, view it on GitHub https://github.com/MystenLabs/sui/issues/20292#issuecomment-2483812239, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMOPFOY7Y62DP2BRIOWVCET2BIWYBAVCNFSM6AAAAABR4KP6ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTHAYTEMRTHE . You are receiving this because you commented.Message ID: @.***>