MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.27k stars 11.21k forks source link

Add ConsensusV2 object type and plumb it through everywhere #20308

Closed aschran closed 9 hours ago

aschran commented 1 week ago

Adds the new Owner type, but these objects cannot be created or used yet.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 7:19pm
3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **multisig-toolkit** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/multisig-toolkit/5vcEFXhKLzG2zr4q1FFbMhneF4TW)) | [Visit Preview](https://multisig-toolkit-git-aschran-cov2-0-mysten-labs.vercel.app) | | Nov 22, 2024 7:19pm | | **sui-kiosk** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-kiosk/DZ8rHimcUBLPsCLJD7Yuh97k9Q1s)) | [Visit Preview](https://sui-kiosk-git-aschran-cov2-0-mysten-labs.vercel.app) | | Nov 22, 2024 7:19pm | | **sui-typescript-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-typescript-docs/C3vDf9LqQn5RNFew5mxdCWMrhyZt)) | [Visit Preview](https://sui-typescript-docs-git-aschran-cov2-0-mysten-labs.vercel.app) | | Nov 22, 2024 7:19pm |
aschran commented 6 days ago

Had a long discussion with Ashok and for now took indexer changes out and replaced with todo!()s. I'll send a dedicated PR for that once this one is in

amnn commented 5 days ago

As a summary of our conversation (so we can pick this up after this PR lands and after other folks have thought about it):

I was pretty convinced by the analogy, but it's worth raising that and seeing how people feel.

Things get tricky when we include coins into the mix. E.g. the paginated coins query in GraphQL is intended to support coin selection, and we can't use club-owned coins to pay for gas, so maybe for that reason we don't want to include club-owned objects in the response from coins, but then we only care about this when paginating over Coin<SUI> and coins pagination works for coins of all denominations, which people may view more like regular objects.