MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.27k stars 11.21k forks source link

rosetta failed pt fix #20411

Closed patrickkuo closed 14 hours ago

patrickkuo commented 1 day ago

Description

do not attempt to parse programmable transaction for failed transactions to avoid parsing error

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 10:37pm
3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **multisig-toolkit** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/multisig-toolkit/8Tri3fhVhQHjdyhxPSPwus11zCmr)) | [Visit Preview](https://multisig-toolkit-git-pat-rosetta-failed-pt-fix-mysten-labs.vercel.app) | | Nov 24, 2024 10:37pm | | **sui-kiosk** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-kiosk/FWbntTXdnDst2FjbYGqHDaHGSXB9)) | [Visit Preview](https://sui-kiosk-git-pat-rosetta-failed-pt-fix-mysten-labs.vercel.app) | | Nov 24, 2024 10:37pm | | **sui-typescript-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-typescript-docs/8vpy8uhzUNuHdaCW5P1qm8pxWurY)) | [Visit Preview](https://sui-typescript-docs-git-pat-rosetta-failed-pt-fix-mysten-labs.vercel.app) | | Nov 24, 2024 10:37pm |
nikos-kitmeridis commented 19 hours ago

Thanks for that @patrickkuo. We most likely need to cherry-pick into the main branch and any other release branch that might exists?

patrickkuo commented 17 hours ago

Thanks for that @patrickkuo. We most likely need to cherry-pick into the main branch and any other release branch that might exists?

Yes, need to cherrypick into main and 1.38 once it’s merged