MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.27k stars 11.21k forks source link

[indexer alt] rename a few structs to make their units more clear #20419

Open emmazzz opened 6 hours ago

emmazzz commented 6 hours ago

Description

While reading/testing this code I found that it can be tough to reason about limits of channels because each channel may have different units: checkpoints, batches, rows. So this PR made some struct names more explicit according to my understanding and added some comments to make channel limits more clear.

Test plan

Existing tests.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel[bot] commented 6 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **multisig-toolkit** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/multisig-toolkit/BwxQfbp8crce3GqJQp8ZTfS2eBaM)) | | | Nov 25, 2024 7:20pm | | **sui-kiosk** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-kiosk/8Ejnh3ciJhCrgEgwn3BtYyF7rH3u)) | | | Nov 25, 2024 7:20pm | | **sui-typescript-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/mysten-labs/sui-typescript-docs/6aDvkCatCWiTMo9BnXxpqzr6DFPo)) | | | Nov 25, 2024 7:20pm |