search

MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.29k stars 11.22k forks source link

CLI: publish binaries so that developers do not need to build them locally #4298

Closed 666lcz closed 1 year ago

666lcz commented 2 years ago

Building/upgrading the CLI can take a long time, let's publish pre-built binaries so that users can just download and use

666lcz commented 2 years ago

@allan-bailey feel free to merge this issue if there's already another issue to track this

Clay-Mysten commented 2 years ago

When these land, please let me know so we can update the install docs. Thanks!

666lcz commented 2 years ago

@ebmifa can we mark this as done given https://github.com/MystenLabs/sui/releases/tag/devnet-0.13.0 ?

exalate-issue-sync[bot] commented 2 years ago

Eugene Boguslavsky commented: This was actually done manually by [~accountid:630bbabdea661fd37d4e557d] . Next release it should be automated, once we verify we can close this.

exalate-issue-sync[bot] commented 2 years ago

Chris Li commented: [~accountid:630bbabdea661fd37d4e557d] [~accountid:635aaadc7d4645af4f026215] have we verified that this is working?

exalate-issue-sync[bot] commented 2 years ago

Eugene Boguslavsky commented: Yes. The binaries now get attached to a release in GH, when a new devnet-X.XX.X tag gets created, see [https://github.com/MystenLabs/sui/releases/tag/devnet-0.15.0|https://github.com/MystenLabs/sui/releases/tag/devnet-0.15.0|smart-link]

amnn commented 2 years ago

Hey @ebmifa! I was just looking into this because it came up during my oncall rotation. As I understand it right now (from looking at our recent releases), we do have prebuilts but:

Are the debug symbols here to stay? They make the binaries quite large (1.1GB for sui) which limits their utility (long build vs long download).

exalate-issue-sync[bot] commented 2 years ago

Eugene Boguslavsky commented: {quote}Only for devnet, (testnet-0.15.1 release didn't come with any).{quote}

Yeah, we have not started publishing binaries yet. Until testnet is up and running and we have the SLA nailed down, then it’d be easier to create them. [~accountid:635aaadc59c794184bca9207] and [~accountid:630bbabdea661fd37d4e557d] , does it make sense to start building the binaries now for testnet?

{quote}They include debug symbols.{quote}

Probably for a while, since we need to debug the environments

amnn commented 2 years ago

Makes sense, thanks for clarifying! This makes total sense for developers running validators and full nodes (and for us). For developers who are using the sui CLI locally, we would likely want a stripped version of sui and maybe sui-faucet for a variety of platforms (eventually) as well.

stefan-mysten commented 1 year ago

We now have releases with the Sui binary, so closing this issue. https://github.com/MystenLabs/sui/releases