MystenLabs / walrus-sites

Walrus Sites: Decentralized Websites using Sui and Walrus.
https://docs.walrus.site/walrus-sites/intro.html
Apache License 2.0
17 stars 16 forks source link

refactor(site-builder): deduplicate args for publish and update #114

Closed Tzal3x closed 1 month ago

Tzal3x commented 1 month ago

Description

Deduplicate the arguments of Publish and Update commands.

There was a duplication of some fields that were shared among the publish and update.

Changes

The overlapping options were consolidated by creating a PublishOptions struct that is then added to both commands. This new struct is also used in the publish_site and update_site functions resolving the "too many arguments" issue.

Testing

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 3:47pm
Tzal3x commented 1 month ago

Thanks for the changes, LGTM! 🥇

Just two nits, then we can get this merged. 🙂

I committed them both directly from gh 👌