At the moment the domain_parsing.ts functions work because the walrus.site is not registered to the public suffix list.
For this reason we use a fixed version of the public suffix list that is downloaded with the v8.0.2 release of parse-domain. This is done so that when the walrus.site gets added to the list, our code will still work.
⚠️ As soon as we include the walrus.site to the public suffix list, (https://github.com/MystenLabs/walrus-sites/issues/64), we should update those functions to parse the domain and subdomains correctly (i.e. given the new version of the suffix list, the existing unit tests should pass).
Plus we need to find a way to update the suffix list periodically npx parse-domain-update during the build process so that we use each time the latest public suffix list, and no longer use the fixed version of it.
Description
At the moment the
domain_parsing.tsfunctions work because thewalrus.siteis not registered to the public suffix list.For this reason we use a fixed version of the public suffix list that is downloaded with the v8.0.2 release of parse-domain. This is done so that when the
walrus.sitegets added to the list, our code will still work.⚠️ As soon as we include the
walrus.siteto the public suffix list, (https://github.com/MystenLabs/walrus-sites/issues/64), we should update those functions to parse the domain and subdomains correctly (i.e. given the new version of the suffix list, the existing unit tests should pass). Plus we need to find a way to update the suffix list periodicallynpx parse-domain-updateduring the build process so that we use each time the latest public suffix list, and no longer use the fixed version of it.Related comment: https://github.com/MystenLabs/walrus-sites/pull/121#discussion_r1687984658
Component
portal
Code of Conduct