Command and its can execute does not affect disabled colors

MysterDru / Xamarin.Plugin.FAB

Xamarin Forms library for a Floating Action Button

36 stars 6 forks source link

Command and its can execute does not affect disabled colors #14

Open tominurmiainen opened 8 years ago

tominurmiainen commented 8 years ago

It would nice if Command's CanExecute will affect visually to the disabled state of the button. If canexecute returns false the button won't do anything so that part works, but its should be disabled as well.

tominurmiainen commented 8 years ago

Actually it seems that the disabled / enabled colors does not correctly affect to the ui. When I disable the button it will change its color but enabling won't change the color back to normal. This has been tested with real devices with android 5 (Lollipop), 6 (Marshmallow). This can be verified with the FAB sample app...

tominurmiainen commented 8 years ago

In Android's viewrenderer / UpdateEnabled function: it seems that calling only UpdateBackgroundColor() does not do anything when setting back to enabled, but if you call SetBackgroundColors before UpdateBackgroundColors it seems to work as expected. I could do a pull request but I'm not sure will this be correct way to resolve this issue.