Closed keatsandyeats closed 6 years ago
I don't know how much this specific guiscript affects performance, and obviously it's only one script, so I wasn't too fussed about it. But in general it might be a good plan to disable or not include as many unnecessary things as possible. Not just for performance, but also for readability and maintainability. As an example, I noticed at least one place where you copied chunks directly from NS2, including dead code that even NS2 doesn't use anymore.
Can you tell me where the dead code is at?
This is my first NS2 mod, and as such, the early code I wrote was likely not the best way of doing things. I'm way overdue for a cleanup pass.
Feel free to suggest improvements as you see them.
Here is one that jumped out to me: https://github.com/MysteriousMilk/NS2_CombatPlusPlus/blob/13b043c7fe97648862504ad0c60756f4fb4161da/source/lua/CPPPointGiverMixin.lua#L64
And later on there's: https://github.com/MysteriousMilk/NS2_CombatPlusPlus/blob/13b043c7fe97648862504ad0c60756f4fb4161da/source/lua/CPPPointGiverMixin.lua#L114
Why even give regular points anyway?
I guess these belong in their own issue. Or how do you want to handle it? I feel like piecemeal PRs for such things would be annoying.
Either way. I need to do a cleanup pass after I get done with the Alien Buy/Upgrade Manager. I can do it then or you can remove chunks of dead code as you find them and send me a PR. Whatever works. I'm going to go ahead and merge and close this issue.
This is as simple as possible, and doesn't remove any associated game logic that is unnecessary if marines can't eject. For example, GUIExoEject still updates every frame.
Fixes #19