search

Mysterken / DLsiteMetadata

Playnite metadata plugin that fetch from DLsite
MIT License
7 stars 0 forks source link

[BUG] Failed to install/Package content invalid #1

Closed sunsetHue closed 5 months ago

sunsetHue commented 5 months ago

Bug Description

Aware this is a WIP fork. Working off install instructions that imply it works.

Packing fresh extracted master folder using Playnite 10.33 toolbox and installing throw the following error notification.

Notification Failed to install "DLsiteMetadata_db03c8d9-645a-4359-aafb-01cda945f301_1_0" add-on. Package content invalid.

Section from playnite.log

30-05 19:01:27.388|INFO |ExtensionInstaller:Installing extenstion/theme D:\Downloads\DLsiteMetadata_db03c8d9-645a-4359-aafb-01cda945f301_1_0.pext
30-05 19:01:27.480|ERROR|ExtensionInstaller:Failed to install extension D:\Downloads\DLsiteMetadata_db03c8d9-645a-4359-aafb-01cda945f301_1_0.pext
System.Exception: Package content invalid.
   at Playnite.Plugins.ExtensionInstaller.InstallPackedFile[T](String packagePath, String nanifestFileName, String rootDir, Func`2 newMan) in C:\projects\playnite\source\Playnite\Plugins\ExtensionInstaller.cs:line 196
   at Playnite.Plugins.ExtensionInstaller.InstallPackedExtension(String path) in C:\projects\playnite\source\Playnite\Plugins\ExtensionInstaller.cs:line 224
   at Playnite.Plugins.ExtensionInstaller.InstallExtensionQueue() in C:\projects\playnite\source\Playnite\Plugins\ExtensionInstaller.cs:line 137

Using the toolbox verify function also throws an error indicating an issue with the manifest. All files are untouched except for being extracted into a folder resembling the toolbox docs.

Toolbox verify addon

Toolbox.exe verify addon E:\DLsiteMetadata_db03c8d9-645a-4359-aafb-01cda945f301_1_0.pext
Verifying addon manifest E:\DLsiteMetadata_db03c8d9-645a-4359-aafb-01cda945f301_1_0.pext ...
Failed to parse addon manifest YAML:
(Line: 1, Col: 6, Idx: 5) - (Line: 1, Col: 7, Idx: 6): While scanning for the next token, find character that cannot start any token.
Mysterken commented 5 months ago

Currently investigating this,

I was locally running the plugin from a Debug MSBuild and adding it as an playnite's "External extensions" hence I assumed (wrongly) that packing it using the Toolbox would work as intended.

From my tests it seems that packing using Toolbox omit the Anglesharp package needed in the .pext, I am not really sure why only this one is missing...

The Toolbox verify function is intended for the manifest file, in this case extension.yaml but it is not needed to pack it from my understanding.

I will try to fix this asap, thanks for the issue.

Mysterken commented 5 months ago

All right, had a lot of trouble with that one but it seems a faulty package install on my end prevented me from packing using the Toolbox.

Fixing this by re-cloning my own repo and re-installing the packages seems to have done the trick.

I also downgraded Anglesharp to 0.9.9 to match the current playnite's version as it is could have caused the issue.

I have now a working .pext that i'm going to upload as release.

Mysterken commented 5 months ago

I have uploaded the first release, let me know if you run into any issues !

https://github.com/Mysterken/DLsiteMetadata/releases/tag/latest

sunsetHue commented 5 months ago

It works without any noticeable errors now. Appreciate the support and your work maintaining this extension.