MysteryBlokHed / databind

Expand the functionality of Minecraft Datapacks.
https://databind.rtfd.io/en/stable
GNU General Public License v3.0
4 stars 0 forks source link

Fix some weird problems #36

Closed MysteryBlokHed closed 3 years ago

MysteryBlokHed commented 3 years ago

One main issue to track things that are very broken.

MysteryBlokHed commented 3 years ago

It looks like some of these problems aren't actually Linux-exclusive, I just found them while I was testing on Linux. I'm not sure how a lot of them occurred.

MysteryBlokHed commented 3 years ago

I'm not sure how most of these came up. There were never any problems testing on Windows, and it seems like some of the things added in older pull requests (eg. proper output folder running databind with no args in #28) have just stopped functioning.

MysteryBlokHed commented 3 years ago

The issue about Windows while loops using full paths as the subfolder prefix was actually just me having a malformed file structure. It might be worth adding some sort of create-namespace subfunction to databind create to stop people from making the same mistake I did 🙃

Previously, the issue was:

- [ ] Fix while loops breaking
    - [ ] On Windows
          On Windows, the while loops function calls seem to insert the entire path to where
          an mcfunction would be generated?
MysteryBlokHed commented 3 years ago

On Linux, it looks like the tokenizer still thinks that it's in a while loop after the :endwhile. I'm trying to fix this now.

MysteryBlokHed commented 3 years ago

It looks like none of the problems were actually Linux-related, I just found them while testing on Linux.

MysteryBlokHed commented 3 years ago

Closed in #37