search

MysteryDash / Offline-PS4-Remote-Play

Enjoy playing on your PS4 from your computer (WLAN/Ad-hoc) without the need of an Internet connection.
Other
258 stars 49 forks source link

Source patching #24

Closed mirh closed 5 years ago

mirh commented 5 years ago

I, for one, applaud the neat inclusion of the manual instructions. For the information behind the patching method never to die.

But it seems a bit barbaric to include the raw bspatch, when (putting aside you could programmatically glue together the tools you mention) you could target the actual functions.. even possibly getting better at forward and backward compatibility. I mean: https://github.com/ioncodes/dnpatch

MysteryDash commented 5 years ago

Nah, it isn't going to happen, Sony pushes changes to the code of the Remote Play when they update it, so it's not always "look for function, remove this, enjoy". There are more checks for updates in the most recent versions of the Remote Play than there were in the previous ones.

mirh commented 5 years ago

I mean, if they add new functions of course it's not like a program can reinvent the wheel for you. But assuming "stuff gets added incrementally" I would see lower maintenance burden (looks at 2.7)

Then, I guess like it would all depends on how much versatile/flexible the patching tool is.. But it doesn't seem like *all that much* required.

MysteryDash commented 5 years ago

I just added a new patch for 2.7 👍 .

mirh commented 5 years ago

Uh... Cool. Well, guess your call for everything eventually.

MysteryDash commented 5 years ago

You asked for it, so I've made it. Not with dnpatch though.

mirh commented 5 years ago

I mean, that was a suggestion. My point was just I loathe seeing "binaries" where "plain information" could be there (especially in source control). But last version works, so.. who cares for the time being? 😄

MysteryDash commented 5 years ago

Oh, I agree with you on that point, but I had to include the binaries for bspatch here because I know that they can easily disappear.