Moving crates with piston crashes the game

Tander commented 3 years ago

General Information

Describe the bug: Crash when moving part of big crate with sticky piston (probably will happen with other ways to move one block of crate multiblock). This issue also corrupts the world (the same error on login).

To Reproduce: Make 2x2x2 crate Try to pull one of its blocks with sticky piston net.minecraft.crash.ReportedException: Exception ticking world

Expected behavior: Crate blocks moves as whole OR Crate blocks doesn't move at all (like furnaces) OR Crates form and break multiblock structure correctly without crashing

Environment Versions

Mystic Mods Versions Druidcraft-1.16.5-0.4.52

Other Versions:

Forge: 36.0.14
Minecraft: 16.5

Logging Information

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available): https://pastebin.com/hu344XxY

noobanidus commented 3 years ago

Duplicate of #91.

noobanidus commented 3 years ago

You're right, this isn't the same crash as I thought it was.

LordGrimmauld commented 3 years ago

Well, Crates as TEs shouldn't move at all in vanilla. Looking at that log, i see quark in there. Quark causing it with their feature of movable TEs is the best guess i have. It also points to a quark piston block mixin in the stacktrace.

Tander commented 3 years ago

Well, Crates as TEs shouldn't move at all in vanilla. Looking at that log, i see quark in there. Quark causing it with their feature of movable TEs is the best guess i have.

Just checked. You're correct. This behavior can be disabled in config:

[automation]
    "Pistons Move Tile Entities" = false

So looks like it's incompatibility with pistons modified by Quark. But still, maybe it's good idea to fix it on Druidcraft's end instead of fixing the same issue with each mod that can move TE.

MysticMods / Druidcraft