search

MysticMods / MysticalLib

Library mod used by the Mystical Mods (Embers, Roots, Blockcraftery and more)
MIT License
11 stars 11 forks source link

Crash when trying to spawn amethyst after adding to Enigmatica 2 #18

Closed Degsdegsdegs closed 5 years ago

Degsdegsdegs commented 5 years ago

Hello! I have a weird issue, I tried adding mystical lib/world and Roots 3 to an Enigmatica 2 server. It seems that whenever amethyst tries to spawn, it crashes. Disabling amethyst lets the server run but obviously, no amethyst.

Crash log.

Degsdegsdegs commented 5 years ago

Link to the enigmatica 2 github issue

noobanidus commented 5 years ago

A couple of questions for you:

Technically the only situation where this could happen is either a) there's a discontinuty between the registered amethyst enum entry (next to impossible), or b) gems are enabled, ores are disabled, but the number of ore to spawn per chunk is not 0.

Either way, there should be a null check in there.

noobanidus commented 5 years ago

I've pushed a potential fix to the Mystical World repository but that would merely mask the issue, as I don't think amethyst would spawn. For some reason it's not registering amethyst's ore block (hence the null value), and that would only happen if ConfigManager.gems.enableOres is set to false, so if you could triple-check your config for me, that would be great.

Degsdegsdegs commented 5 years ago

The config as it was during the crash

Looks like you were correct, in the gems section I had

enableAmythest=true

but

enableOres=false

Sorry about that!

noobanidus commented 5 years ago

No worries, it exposed the fact that I was checking "hasGem" instead of "hasOre" when trying to generate -- so there was a bug there as well!