search

MysticMods / MysticalWorld

Library mod for use with the Mystic Mods (Embers, Roots, Gadgetry, Mystic World, etc.)
MIT License
26 stars 30 forks source link

Deerhelmet causing lag on server #236

Closed SaphieNyako closed 3 years ago

SaphieNyako commented 3 years ago

General Information

Describe the bug: Deerhelmet causes lag on my server. Only 1 was in use. Used up 20% of server thread.

To Reproduce:

  1. Find a Deer and Kill it
  2. Craft a helmet from it remains
  3. Wear helmet and happy dead deer you just killed will heal you T_T

Expected behavior: The deers spawning where spamming find path find path.

Environment Versions

Mystic Mods Versions

Logging Information

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available):

Latest Log (if necessary):

Additional Information

Screenshots (if available):

image

Additional context (optional):

noobanidus commented 3 years ago

Thanks for the confirmation and the reminder, I forgot to open an issue myself. I'm going to convert this to using a particle isntead, hopefuully.

Recommandtion with spark: if you look in the top right there's a drop-down that allows you to select mappings, "MCPForge 1.6.4" should work with 1.16.5 also and help clear up which function is which.

Vaelzan commented 3 years ago

Just chiming in to say that I've had this happen in 1.15.2 as well, causing a server crash multiple times until we removed all the spirit deer + helmets. I just forgot to make the report when it was happening. No idea if you still fix 1.15.2 bugs but I can just blacklist the recipe in the pack if not.

noobanidus commented 3 years ago

I won't be making any changes to 1.15.2 at this point, sorry. It's too difficult to maintain multiple versions even when the codebase is otherwise identical.