Blame report: ConfiguredFeature not registered properly (related to stonepetals)

MysticMods / MysticalWorld

Library mod for use with the Mystic Mods (Embers, Roots, Gadgetry, Mystic World, etc.)

MIT License

27 stars 30 forks source link

Blame report: ConfiguredFeature not registered properly (related to stonepetals) #272

Closed Not-February closed 3 years ago

Not-February commented 3 years ago

General Information

Describe the bug: I am assuming that something related to recent stonepetal changes might be causing this? Whatever is going on, it is messing with an alarming amount of biomes(mostly vanilla mountainy biomes, but also various other mod biomes with exposed stone on their surface)

Environment Versions

Mystic Mods Versions

Mystical World 0.3.2.16

Other Versions:

Forge: 36.2.0
Minecraft: 1.16.5

Logging Information

Blame Report: https://gist.github.com/Febilian/5b119d69fcee89e97b6a2623ffe26428

noobanidus commented 3 years ago

That's odd, the features should be registered on-the-fly once the dimensional placement is applied. It's possible I missed a step.

noobanidus commented 3 years ago

(For the record, this is a minor issue; registering configured features is good practice, but only essentials for certain mods/methodologies.)

Not-February commented 3 years ago

I mean, I've seen firsthand how unconfigured features can flat out stop the loading of features of any other mods that load after them. Did something change in Forge to fix that in the past few months?

noobanidus commented 3 years ago

It depends on the context, really. If there are red error messages with "unable to load json" then yeah, it's can definitely be a problem as it stops loading the rest of the biome.

noobanidus commented 3 years ago

Ahah! I was actually registering the properly configured feature but failing to update the reference, so it was place the raw, original configured feature (without the dimensional placement), hence this issue.

Should be fixed in the next release.