MysticMods / MysticalWorld

Library mod for use with the Mystic Mods (Embers, Roots, Gadgetry, Mystic World, etc.)
MIT License
27 stars 30 forks source link

[1.12.2] Exclude FakePlayers from DamageHandler::onLivingDamage for the Blessed attribute #284

Open Pinhead-Larry opened 2 years ago

Pinhead-Larry commented 2 years ago

Hi, thank you for your time. I've been encountering a crash due to a mod incompatibility with LittleMaidMob (https://github.com/firis-games/LittleMaidReengagedFirisPatch) The author says that it's due to the effect BLESSED, where the player counterattacks with fire when attacked by undead. The mobs from LittleMaidMob are "disguised" as players he said, and so the game crashes because it doesn't know how to handle it when they are attacked. I can confirm this, as the game only crashes when the mobs from LittleMaids are attacked by undead mobs.

(https://github.com/firis-games/LittleMaidReengagedFirisPatch/issues/71) (Google translate)

He said that it will be nearly impossible to fix on their mod side, but easy on MysticalWorlds side. Is it possible for this to be fixed? Thank you. crash-2021-10-23_03.02.34-server.txt .

noobanidus commented 2 years ago

I can add a check for fake players, sure.