search

MysticMods / Roots

Home of the Roots Minecraft Mod
GNU Lesser General Public License v3.0
44 stars 33 forks source link

Comparator measuring Pyre craft causes ticking block crash #749

Closed WaitingIdly closed 3 years ago

WaitingIdly commented 3 years ago

General Information

Describe the bug: When detecting the comparator level of the Pyre, if the Pyre has a valid craft/ritual, the game crashes. This is consistently repeatable in isolated environments. Could not cause it to occur with the Fey Crafter.

To Reproduce:

  1. Load world with Roots & dependents.
  2. Place Pyre
  3. Toss ingredients required to craft something (or do a ritual) with the Pyre onto the Pyre
  4. Place Comparator to measure the Pyre
  5. Crash, and crash on attempting to reload the world.

Expected behavior: Not crash

Environment Versions

Mystic Mods Versions

Other Versions:

Logging Information

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available): https://paste.ee/p/bqiOs

Latest Log (if necessary):

Additional Information

Screenshots (if available):

a person about to crash image

Additional context (optional):

First identified here: https://github.com/Divine-Journey-2/main/issues/292, and then reproduced with only roots for this bug report.

noobanidus commented 3 years ago

That is ... weird.

noobanidus commented 3 years ago

This'll be fixed in the next release but there may be issues with the comparator output not being correct.

noobanidus commented 3 years ago

3.1.2 should contain all these fixes. Please let me know if there are further issues with the comparator.

One of those issues might be that the outputs aren't properly documented anywhere... and I'm not sure if the logic is correct, but I wanted to get the fix out on the runic crafter.