Runed Smasher breaks unbreakable blocks

WaitingIdly commented 2 years ago

Describe the bug: Runed Smasher can break bedrock via 3x3 mining.

To Reproduce:

Break (valid pickaxe) block adjacent to bedrock in such a way that the mined area of the Runed Smasher would be the bedrock
observe
Expected behavior: only break blocks <= mining level

Mystic Mods Versions

Other Versions:

Conflicting mod (if regarding mod integration):
Other mods you think could cause issues:
Forge:
Minecraft: 1.12.2
Modpack (if available): https://www.curseforge.com/minecraft/modpacks/divine-journey-2/files/3464189, but also occurs with only Roots.

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available): N/A

Latest Log (if necessary):

Screenshots (if available): """screenshot"""

Additional context (optional):

DoomRater commented 2 years ago

I can't believe I never tried to see if that was an exploit possible

WaitingIdly commented 2 years ago

minor update: if you break with silk touch, you get the bedrock block - otherwise its just destroyed.

noobanidus commented 2 years ago

Yeah, I swear I had code in place to ensure this didn't happen. I'm wondering if it's special-cased and my code doesn't catch it.

noobanidus commented 2 years ago

This isn't necessarily the best solution, but I've basically added a block blacklist with bedrock in it by default.

MysticMods / Roots