search

MysticMods / Roots

Home of the Roots Minecraft Mod
GNU Lesser General Public License v3.0
44 stars 32 forks source link

Crash between Roots and TFC Florae #790

Open Nohicom opened 1 year ago

Nohicom commented 1 year ago

General Information

Describe the bug:

Game crashes on load when Roots and TFC Florae are both installed. Gives an error report of "Invalid ingredient for recipe roots:wolf" in the log.

To Reproduce:

Install TFC Florae on a modpack that has Roots installed, game will not load to main menu.

Environment Versions

Mystic Mods Versions

Other Versions:

Logging Information

Latest Log (if necessary):

https://mclo.gs/UXJxj4X

Additional context (optional):

The game works with only Roots and base TFC, as well as a few other mods. I even tested all the dependency mods that TFC Florae requires (mixin booster, bansoukou, firmalife, justenoughids, and loliasm) and it still works fine. It's only the actual TFC Florae mod itself that causes this issue. I also tested the TFC Florae mod without Roots (but still with all the other mystic mods) and it works fine, so it's specifically an interaction between these two mods.

noobanidus commented 1 year ago

Try using CraftTweaker to remove wolves from the pacifist category and summon creatures... I'm assuming TFC Florae is doing some sort of registry replacement with the wolf.

Nohicom commented 1 year ago

I tried to remove wolf from Pacifist, SummonCreatures, AnimalHarvest, RunicShears, and SummonCreatures LifeEssence using crafttweaker, and it still crashes on load. Confusingly, I reached out to the TFC Florae dev too and they said that their mod doesn't even do anything with entities in the first place. Do you have any other idea what might be wrong?

The TFC Florae file doesn't even seem to be causing the problem, it makes modifications to the base TFC mod using Bansoukou that cause the crash. However, as far as I can tell those modifications don't do anything to the entity registry either. I did double check and the ritual works fine in TFC even when trying to summon a vanilla wolf, it will spawn and immediately get swapped out for a TFC wolf. So I'm not sure why a mod that isn't supposed to affect entities would cause that interaction to break.

noobanidus commented 1 year ago

Ah, I must've misunderstood the error message -- it's not an entity replacement, but the ingredient for the recipe for summoning a wolf that's a problem. Are you sure you removed just the Summon Creatures recipe? The life essence is separate to that.

Nohicom commented 1 year ago

I tried with just the Summon Creatures removal, as well as with everything entity-related I could find in CraftTweaker, and none of it is working. Here's the CraftTweaker script and crash log from my latest attempt. As a side note, even with all the commented-out lines in the script enabled, it still crashes.

CT script: https://pastebin.com/fZgVyq2x Minecraft log: https://mclo.gs/x9t2UC2