MysticMods / Roots

Home of the Roots Minecraft Mod
GNU Lesser General Public License v3.0
44 stars 33 forks source link

[BUG] Growth Infusion attempts to grow modded Grasses #797

Closed anabsolutesloth closed 7 months ago

anabsolutesloth commented 1 year ago

General Information

Describe the bug: The Growth Infusion spell will target and attempt to grow modded Grass blocks, such as TConstruct's Slimy Grass, The Betweenlands' Swamp Grass, or even Thaumcraft's Ambient Grass. This isn't much of a problem with the standard version of the spell, but when you introduce the AoE Modifier, it becomes a problem.

To Reproduce:

  1. Install Roots and deps.
  2. Get a Staff with Growth Infusion and cast it on a modded Grass block.
  3. Experience bug.

Expected behavior:


Environment Versions

Mystic Mods Versions

Other Versions:

Other mods in more minimal instance:


Additional Information

https://user-images.githubusercontent.com/63694982/211470944-a2792c92-24e2-44e4-b716-03891d833984.mp4

ByThePowerOfScience commented 7 months ago

These blocks need to be added to a blacklist in the config, I'd imagine. I don't see anything hardcoded that disallows even vanilla grass, so it's just a configuration option.

anabsolutesloth commented 7 months ago

It appears to be that the former two implement IGrowable, which is checked for by the canGrow() function of the Growth class, which is invoked by the spell I would argue that it would still be valuable to have such blocks from commonly used mods as a default part of the blacklist, seeing as some other mods' items have been added to the default blacklist for the Ritual of the Spreading Forest.

ByThePowerOfScience commented 7 months ago

I would argue that it would still be valuable to have such blocks from commonly used mods as a default part of the blacklist, seeing as some other mods' items have been added to the default blacklist for the Ritual of the Spreading Forest.

Sadly, it's not realistic to do that for everything. You should ask the modpack developer to add those blocks to the blacklist.