search

Mystixor / BotW-Save-Editor

This is a Save Editor for BotW (Wii U) written in C++.
8 stars 0 forks source link

Unusual Runtime Termination #2

Open NateHevens opened 3 years ago

NateHevens commented 3 years ago

So... here's an issue...

Screenshot (52)

What's happening? Am I missing something?

I have the base game, DLC, and update. I downloaded the main package from here, which includes jsons. I even grabbed mingw32 (I think... it was a bit confusing). What's happening, here? What am I missing?

Polyfish0 commented 3 years ago

Well i'm currently out of the code, but is it a WiiU or Switch save state?

NateHevens commented 3 years ago

Well i'm currently out of the code, but is it a WiiU or Switch save state?

Ooh sorry. WiiU/CEMU.

Polyfish0 commented 3 years ago

Ok is it possible for you to share your save files?

Polyfish0 commented 3 years ago

Currently I have not much time, but i will look in it later. I'm also currently not at my computer.

NateHevens commented 3 years ago

Before I do that... it was edited via Marc Robledo's online save editor. I use that a lot, especially because I don't want to get every shrine... heh... so I just complete those via the save editor... :D

Could that be part of the problem?

NateHevens commented 3 years ago

Here's my most recent save...

game_data.zip

Thanks for any help you can provide...

Mystixor commented 3 years ago

Hey, great to here my editor is still not obsolete. At the same time, that's not very fortunate at all, as I have to admit it to be a very poorly coded program (basically my first exploration of C++). I might be able to fix these issues nowadays but sadly due to my studies my free time is approximately 0. I am putting this on my list for semester break though, so hopefully I can complete this project then. I know this isn't very helpful right now, just wanted to give a little update if anyone's interested ^^'

NateHevens commented 3 years ago

Hey, great to here my editor is still not obsolete. At the same time, that's not very fortunate at all, as I have to admit it to be a very poorly coded program (basically my first exploration of C++). I might be able to fix these issues nowadays but sadly due to my studies my free time is approximately 0. I am putting this on my list for semester break though, so hopefully I can complete this project then. I know this isn't very helpful right now, just wanted to give a little update if anyone's interested ^^'

I would love that. Marc Robledo's online editor has some... limitations. Especially as it pertains to fan mods like Second Wind and such. Regardless, keep us updated if you do get around to working on this again.

Polyfish0 commented 3 years ago

Which game version do you used to generate this save state? I ask because maybe Nintendo did not changed the save file structure in 1.6.0 and also did not changed the version id for save states.

NateHevens commented 3 years ago

Which game version do you used to generate this save state? I ask because maybe Nintendo did not changed the save file structure in 1.6.0 and also did not changed the version id for save states.

I'm at work right now, but when I get home (after 2:30pm EST) I'll check the version and let you know.

Polyfish0 commented 3 years ago

So I will now look in to this, because all my school teachers are sick, so I have no school today :) I hope I will find something to fix this. Also, the rewrite of the editor I started three weeks ago is not finished, and the export is kinda buggy. Some fields in the exported JSON changes randomly to null instead of their real value qwq

Polyfish0 commented 3 years ago

Is it possible that you have converted your save state from the switch version to the Wii U version or was this save state created by CEMU/WiiU? I ask because the newest Switch game version is 1.6.0 and for the Wii U is 1.5.0 the newest version.

NateHevens commented 3 years ago

Is it possible that you have converted your save state from the switch version to the Wii U version or was this save state created by CEMU/WiiU? I ask because the newest Switch game version is 1.6.0 and for the Wii U is 1.5.0 the newest version.

It's directly from CEMU.

Polyfish0 commented 3 years ago

Ok thanks

Polyfish0 commented 3 years ago

Sorry that I'm currently not working at the Problem but I have currently not much free time because I have to study for my school exams.

NateHevens commented 3 years ago

Sorry that I'm currently not working at the Problem but I have currently not much free time because I have to study for my school exams.

Bruh. You ain't gotta apologize for school stuff. I totally understand that. Take your time. That goes for Mystixor, as well.

Marc Robledo's online save editor (limited though it is... can't read fan mods in a save, can't edit flags, etc) is fine for now. I can wait. Y'all are good.

Polyfish0 commented 3 years ago

Thanks man ^^ Yeah, I just wanted you to know that, because I think it's kinda rude just not to answer anymore. This is now my last school week for this year. Then I'm in an internship for ~4 weeks, and then I have summer holidays. I think in the summer holidays I can work at that.

But because of how the save editor works, it's unlike that it will get the modded save fields from itself. To accomplish that, it's necessary to add the hash values for the modded save fields to the JSON file. But when that's done, it should work.

Also, I'm currently working on a rewrite, so the save editor also uses the right data types. Because currently, every entry will be exported as a number. Even if it's a string. The rewrite will also completely compatible with Linux ^^. But the rewrite has currently some problems, where some fields in the exported JSON are just null, and I have currently only a slight idea why. Also, I could work at it with my notebook (I hope that's the right word for a mobile computer xD) at school, but I'm forgetting every time when I'm home to upload new source code to Git qwq.