MythTV-Themes / blue-abstract-wide

The MythTV blue-abstract-wide theme
Other
5 stars 21 forks source link

Various updates to music and gallery UI #22

Closed ijc closed 4 years ago

ijc commented 4 years ago

Been sitting on some of these for a while, about time I sent them upstream. I'm running on v30 but looking at:

mythtv$ git log origin/fixes/30..origin/master -- mythtv/themes/default-wide/

it doesn't look like too much has changed so the changes ought to be good right up to master.

Here are the individual commit messages for easier reference:

$ git log --no-decorate origin/master..misc-update 
commit 9344971709c5e56845473d083e9407b83ccee9db
Author: Ian Campbell <ijc@hellion.org.uk>
Date:   Sat Mar 21 12:23:59 2020 +0800

    music-ui: adjust artist/album string wording

    This is purely a preference thing, but I feel it makes more sense this way
    round especially for compilation albums.

    Taking for example the track:

        Various Artists - Terrorizer: Fear Candy 92/05-40 Watt Sun - Between Times.flac

    Previously:

        Between Times
        From the album Terrorizer: Fear Candy 92 by the artist 40 Watt Sun

    But the album "Terrorizer: Fear Candy 92" isn't by "40 Watt Sun", it's a
    compilation by various.

    Now it reads:

        Between Times
        By "40 Watt Sun" from the album "Terrorizer: Fear Candy 92"

    Which I think is an improvement.

commit db1bb7c2f4d371b965d94d42b2984d14e09b1bee
Author: Ian Campbell <ijc@hellion.org.uk>
Date:   Sat Mar 21 12:23:01 2020 +0800

    music-ui: typo: compilationartist

    The `compilationartist` field in the info view was always empty due to this.

commit 274ba8801f781cdb585e6028fdea6111b0cc36fc
Author: Ian Campbell <ijc@hellion.org.uk>
Date:   Tue Mar 10 17:58:43 2020 +0800

    music-ui: Widen last played and play count boxes

    The last played is cut off for me in UK dates ("Fri 31 Aug 2018").

    The right edge of the "Next" box (which is to the left of lastg
    played) is at 200+600=800 so this leaves a buffer of 10px before
    the new location at 810.

    The right edge of the time box (which is to the left of the play
    count) is at 715+140=855, so drop this to 715+125=840 to allow
    10px before the new location of the play count at 850.

commit 6bfcc021b5387c69acf23b3eac02d5c45659e0d0
Author: Ian Campbell <ijc@hellion.org.uk>
Date:   Fri Dec 21 10:57:40 2018 +0000

    music-ui: Add lyrics view

commit 3f8e6fc7a125291daba87bc0f6be24c11cfe64df
Author: Ian Campbell <ijc@hellion.org.uk>
Date:   Sun Sep 2 17:50:24 2018 +0100

    image-ui: update for modern requirements

    I made these changes a long time ago, I believe based on the default theme and
    almost completely replaced the previous code, which didn't work well (I think
    it may have been for the old gallery plugin).

    It's not brilliant, but it makes the new gallery functionality basically usable.