V33: fixes and updates

[ijc]

I've been running most of these on V32 for quite a while, some are just personal preferences (e.g. using posh quotes and including the disc number) others are tweak for cut off text, alignment etc.

I'm now running V33 and this exposed some errors when trying to access the music settings for the player. It looks like the theme here actually changed in 2014/2015 (https://github.com/MythTV/mythtv/commit/d9c6036f626d4b0e0e7eafed0001fad397450abf and https://github.com/MythTV/mythtv/commit/f64b513401d9278ad8ac202f942e06a525a62035 I think is most of them) so I don't know if this was broken for several releases (perhaps as long ago as V28) and I didn't notice (it's not a screen one visits very often) or if something in V33 got stricter.

[gigem]

The change to the timedate field in base_schedule.xml causes it to overlap with the template field. Please remove that change and I'll accept the rest.

[ijc]

@gigem done!

[gigem]

ijc, I think you misunderstood my critique. In the unpatched base_schedule.xml, there is the following:

        <textarea name="template" from="base_textarea">
            <area>625,10,300,36</area>
            <scroll direction="horizontal" rate="35"/>
            <template>%Using |TEMPLATE| Template% 
       </template>
        [...]
        <textarea name="timedate" from="base_textarea">
            <area>945,10,280,36</area>
            <align>right,vcenter</align>
                <cutdown>yes</cutdown>
    </textarea>

Note how "template" ranges from 625 to 925 in the x direction and "timedate" then starts at 945 in the x direction. In your patch, you have the following.

         <textarea name="timedate" from="base_textarea">
-            <area>945,10,280,36</area>
+            <area>900,10,320,36</area>
             <align>right,vcenter</align>

This moves "timedate" back to start at 900 which then overlaps with "template" which still goes to 925. That is what I would like you to fix.

[ijc]

Ah, got it, I found the wrong commit the first time.

I'll have a look at reworking over the weekend.

[ijc]

@gigem I've shrunk the template field a little to accommodate the larger date time, it has got horizontal scroll enabled so I hope 270 is wide enough.

I've never actually seen the template field appear though, I think (...assume) I do use templates when I record a movie (i.e. it gets the storage group correct automatically) so I'm not sure why not though.