DVD: Some DVD menus broken when using VAAPI and VDPAU

mark-kendall commented 4 years ago

issue confirmed with https://www.mir.com/truncated-groundhog.iso sample provided in the original ticket.
no issues seen with software decoding
definite problem with VAAPI
not confirmed yet (by me) with VDPAU (as reported in the original ticket) but per analysis below, I would expect it to be broken as well

A quick debug shows that we are resetting the video buffers virtually every frame because:-

the aspect ratio is overridden in the DVD decoder
both VDPAU and VAAPI decoders need to be reset if there is an aspect ratio change for MPEG2
we think the aspect ratio is constantly changing because we are comparing to the stream aspect - not the overridden aspect

So I couldn't reproduce this before because all of my disks are 16:9 aspect ratio (i.e. not overridden).

I think this is a fairly simple fix.

mark-kendall commented 4 years ago

and there's even a note in the code about it:-

mark-kendall commented 4 years ago

Fix has gone into master and fixes/31. Can't see any regressions with other DVDs or MPEG2 content - so closing as fixed.

MythTV / mythtv