search

MythTV / mythtv

The official MythTV repository
https://www.mythtv.org
GNU General Public License v2.0
701 stars 346 forks source link

QtWebKit deprecated: MythMusic plugin #328

Open stuarta opened 3 years ago

stuarta commented 3 years ago

MythMusic plugin uses QtWekKit which is deprecated

ijc commented 3 years ago

I did the trivial/easy part in #334.

The remaining use is in editmetadata.cpp where one can search for images for artist/genre/album. I've not actually managed to use it successfully (couldn't figure out how to actually use an image once I'd browsed to it and downloaded it).

I was thinking I would simply make it a compile time thing and omit that functionality if no browser is present, does that sound ok? Would it be better to just remove the menu items entirely or to keep them but wire them up to a "no browser available" dialog? I'll go with the former (easier) unless someone has a strong opinion...

paul-h commented 3 years ago

I'd rather not go down this route of disabling a bunch of stuff like this. Where does it end? Before you know it you have crippled all the plugins or worst end up with the monstrosity that is the program info popup \0/

Let me see how difficult it will be to convert the webbrowser to use QWebEngine first.

linuxdude42 commented 3 years ago

I didn't think this was intended to be permanent; just a short term change until the web browser could be rewritten. I look forward to hearing how difficult you think that will be.

garybuhrmaster commented 3 years ago

Given that this issue was closed with the merge, but the merge reverted, should this issue not be re-opened for tracking purposes?

ijc commented 3 years ago

I had assumed that the change would be temporary until someone came along with the tuits to port to the new thing. I appreciate that for some plugins the web stuff is pretty critical and building them without would indeed be crippling them (so it would be better to disable entirely, which I think is what is done for those ones already) but in the case of mythmusic it is used for none-core functionality which I judged could be lived without if necessary, but since Paul feels differently I'm ok with it having been reverted.

I guess at least we have this change in our back pocket for if we find ourselves needing to choose between releasing with >=Qt6 support only and releasing with mythmusic, frankly that feels like something which is unlikely to arise in practice since I expect it is some way off before Qt5 support is actually removed, although it might be more of an issue for distro packagers who may have less control over the switch to qt6 on their platform, even then it's probably not very likely to happen before the web stuff can be ported over I suppose.

Probably this ticket should be reopened though, yes, since there is still a task to be done.

stuarta commented 3 years ago

Reopening as the change was reverted