MythTV / mythtv

The official MythTV repository
https://www.mythtv.org
GNU General Public License v2.0
710 stars 346 forks source link

Live TV: channel changing script invoked twice when typing channel number #622

Closed JanCeuleers closed 1 year ago

JanCeuleers commented 2 years ago

What steps will reproduce the bug?

  1. Enter Live TV and select a source/input that is configured with a channel changing script. In my case this is a pvrusb2 tuner connected to the analogue outputs of an STB which needs its channels changing by means of IR.
  2. Navigate to another channel by typing its channel number followed by enter.
  3. Observe that the channel changing script is called twice, such that the channel number is blasted to the STB twice.

How often does it reproduce? Is there a required condition?

This is 100% reproducible on my system.

What is the expected behaviour?

The channel changing script should be called only once when changing channels. In other channel changing scenarios, such as when starting a recording, or in Live TV when selecting another channel from the programme guide, the channel changing script is indeed invoked only once. EDIT: Actually, I have now observed this issue when at the beginning of a recording as well.

What do you see instead?

The channel changing script is invoked twice when the channel is changed in Live TV by typing the channel number and pressing enter. My STB can accept channel numbers having 1, 2 or 3 digits, so emitting the channel number twice is problematic for channel numbers that have only 1 or 2 digits (e.g. typing 1 enter results in channel 11, typing 23 results in a change to channel 232 immediately followed by a change to channel 3, etc.).

Additional information

I am not a frequent Live TV user, so I can't be 100% sure, but I believe that this bug was not present in 31/fixes from which I recently upgraded.

jhoyt4 commented 2 years ago

Possibly related or a duplicate of Issue 584

JanCeuleers commented 1 year ago

I can no longer reproduce this issue in 32, so I propose to close.