search

Mytherin / Tibialyzer

Tibialyzer is an extension made for the MMORPG Tibia. It automatically scans the server log and messages from the Tibia client by reading its memory, and gathers various statistics, such as loot found from creatures, damage dealt by party members and experience gained every hour.
Other
182 stars 60 forks source link

Tibialyzer leaks process handles during memory scanning #156

Closed Oddegamra closed 7 years ago

Oddegamra commented 7 years ago

It is my understanding that Tibialyzer has an internal timer that periodically scans Tibia's memory using OpenProcess/ReadProcessMemory. Assumedly, the code was taken from CodeProject, which usually isn't very good for serious programming due to severely lacking quality control. In any case, the process handle returned by OpenProcess should always be closed with CloseHandle after the scanning is done to avoid leaking open process handles and depleting system memory.

Mytherin commented 7 years ago

Should be fixed in commit 3d5a492b04dd76ed6fac862329a71d6bb93bc4cf.