Remote Port Forward - 2.2 Updates

MythicAgents / Apollo

A .NET Framework 4.0 Windows Agent

BSD 3-Clause "New" or "Revised" License

439 stars 89 forks source link

Remote Port Forward - 2.2 Updates #34

Closed thiagomayllart closed 3 years ago

thiagomayllart commented 3 years ago

Hello everyone! I've recently updated the port forward module to fit the 2.2 updates. It is working the same way as the previous pull request in: #18

djhohnstein commented 3 years ago

Looks pretty good! I really only have one gripe, which is the structure of the rportforward data. Being a series of 5 nested dictionaries is gonna make it hard for other maintainers to read and understand what data is supposed to be fed into the variety of functions that beast is thrown into. Thanks again for your time and effort on this!

thiagomayllart commented 3 years ago

Perfect!! I'll be making the modifications as soon as possible!! Thank you again for the response 😃

thiagomayllart commented 3 years ago

Hi @djhohnstein !! I've just update the structure of rportforward data and task.display_args. I think it should be fine now 😃