MythrilBagels / Create-Alloyed

A Create addon that adds *two new metals, Bronze and Steel
Other
22 stars 22 forks source link

Pickaxe doesn't work #81

Closed tiendatbinhan closed 1 year ago

tiendatbinhan commented 1 year ago

VERSIONS Minecraft - 1.18.2 Create - 0.5.1.b Flywheel - 0.6.8.a Alloyed - 1.5a

DESCRIPTION The pickaxe loses its functionality in Survival Mode. They cannot mine anything.

STEPS TO REPRODUCE This is very easy to reproduce. Here are some ways to do it:

NightmareTwilight commented 1 year ago

Duplicate of #77 . The issue seems to be caused due to an error with the "minecraft:mineable/pickaxe" tag.

tiendatbinhan commented 1 year ago

Duplicate of #77 . The issue seems to be caused due to an error with the "minecraft:mineable/pickaxe" tag.

So, when will the hotfix of this be released?

NightmareTwilight commented 1 year ago

Duplicate of #77 . The issue seems to be caused due to an error with the "minecraft:mineable/pickaxe" tag.

So, when will the hotfix of this be released?

No idea, not a dev, just noted what the error was since I had the same issue, and discovered the cause while looking through the debug log. It also affected axes. Basically, when one instance of the tag fails, Minecraft removes the tag all together, which isn’t just a mod issue, but a general one, which has been reported to Mojang. Until they fix it (basically by ignoring the one that failed), every single one needs to make sure that it doesn’t fail, otherwise everything breaks.

tiendatbinhan commented 1 year ago

Duplicate of #77 . The issue seems to be caused due to an error with the "minecraft:mineable/pickaxe" tag.

So, when will the hotfix of this be released?

No idea, not a dev, just noted what the error was since I had the same issue, and discovered the cause while looking through the debug log. It also affected axes. Basically, when one instance of the tag fails, Minecraft removes the tag all together, which isn’t just a mod issue, but a general one, which has been reported to Mojang. Until they fix it (basically by ignoring the one that failed), every single one needs to make sure that it doesn’t fail, otherwise everything breaks.

Ah, I've found a quick solution. There's an inconsistency between pickaxe.json in the mod file and in this repository. The pickaxe.json in the mod file has two extra lines comparing to one in this repository. If remove these extra lines, the pickaxes and axes will work as usual.

MrFastZombie commented 1 year ago

Ah, I've found a quick solution. There's an inconsistency between pickaxe.json in the mod file and in this repository. The pickaxe.json in the mod file has two extra lines comparing to one in this repository. If remove these extra lines, the pickaxes and axes will work as usual.

I had to delete wooden_doors.json to get axes working, but it looks like it is not supposed to be there anyways. Deleting those lines in pickaxe.json only made picks work for me.

FortressNebula commented 1 year ago

Fixed. Modfile has been taken down and the fixed version was uploaded.

FortressNebula commented 1 year ago

(Thanks to everyone for being helpful about the issue too, very much appreciated!)