search

Myzwer / foothillschurch

Bootcamp II is a wordpress theme (as well as an inside joke) designed to suit the needs of foothillschurch.com. It makes use of webpack, Babel, Sass, Tailwind, Browsersync, PostCSS, ESLint, Stylelint, Prettier and more. It is meant for that site, but if you can use it by all means go for it.
1 stars 1 forks source link

Optimize tab option conditions #14

Closed rain2o closed 2 months ago

rain2o commented 2 months ago

https://github.com/Myzwer/foothillschurch/blob/d75494784caf988edbcdb95afebe7becdca009e7/includes/shortcodes.php#L27-L38

This can be optimized a bit. You can remove the two elses that just assign an empty string in favor of starting with an empty string.

$open_in_tab_modal = '';
if ( isset( $atts['tab'] ) ) {
  $tabOption = strtolower( $atts['tab'] );
  if ( $tabOption === 'y' ) {
    $open_in_tab_modal = " target='_blank'";
  } elseif ( $tabOption === 'cc' ) {
    $open_in_tab_modal = ' data-open-in-church-center-modal="true"';
  }
}