search

Myzwer / foothillschurch

Bootcamp II is a wordpress theme (as well as an inside joke) designed to suit the needs of foothillschurch.com. It makes use of webpack, Babel, Sass, Tailwind, Browsersync, PostCSS, ESLint, Stylelint, Prettier and more. It is meant for that site, but if you can use it by all means go for it.
1 stars 1 forks source link

Expandable list items semantically questionable #58

Closed rain2o closed 1 day ago

rain2o commented 1 month ago

https://github.com/Myzwer/foothillschurch/blob/effc5bbf81497ae99f0561ab7849412fe9272bfd/outreach.php#L83-L96

I'm not sure if this is really semantically correct, to use sibling list items to title and expandable details. I think the best option would be to use the native details disclosure element. That would be best since it's semantically correct (great for SEO and a11y), plus no JS needed.

If not, maybe you could try something like the description list (dl) with description title (dt) and details (dd). That would be a secondary option but still probably better than lis.

rain2o commented 1 month ago

This also applies to the resource bank list https://github.com/Myzwer/foothillschurch/blob/effc5bbf81497ae99f0561ab7849412fe9272bfd/resources-bank.php#L86-L92

rain2o commented 1 month ago

I think this case is OK... but I'm not sure how well (if at all) it will work for accessibility.

https://github.com/Myzwer/foothillschurch/blob/effc5bbf81497ae99f0561ab7849412fe9272bfd/components/blocks/faq-long.php#L39-L45

I would say that this isn't as big of an issue as the cases I mentioned earlier, but it still might be best to change this to use the details disclosure element if possible