search

N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
20 stars 26 forks source link

Adding sound effects on correct and wrong guess #12

Closed DevilzzNikhil closed 1 year ago

DevilzzNikhil commented 1 year ago

Playing music on incorrect and correct ans and Add feature to reveal ans after all trials @N-Shar-ma

DevilzzNikhil commented 1 year ago

I would like to work on this

N-Shar-ma commented 1 year ago

Hmm, this might be a nice addition. What audio / music exactly do you have in mind for correct and incorrect answer? Also how would you go about revealing all answers at the end?

DevilzzNikhil commented 1 year ago

@N-Shar-ma not sure about answers but for music i have some game music for that some https://www.storyblocks.com/audio/search/correct+answer+sound+1+sound+effect i can use this website for that

and for answers i think we can tell the correct ans after end of 3 trials

N-Shar-ma commented 1 year ago

@DevilzzNikhil For now, the sound effects on correct and wrong guess seems like a feature I'd like to be present in the game. Simple bright sounds should go well with the game's feel. Additionally please add a volume icon in the top right of the game screen to toggle sound on and off. Looking forward to a PR!

N-Shar-ma commented 1 year ago

@DevilzzNikhil Any updates?

Gauravdarkslayer commented 1 year ago

Hey @N-Shar-ma is @DevilzzNikhil still on it, if not then you can assign this issue to me. Thank you !!

N-Shar-ma commented 1 year ago

Go ahead, @Gauravdarkslayer !