N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
20 stars 26 forks source link

Added Author Feature and additional description to Contrib section of READ.md #14

Closed McCune1224 closed 1 year ago

McCune1224 commented 1 year ago

Features added as mentioned in #6. LMK if you want anything tweaked. Tried to maintain the same syntax used within the project when adding HTML and CSS associated with the author.

McCune1224 commented 1 year ago

Thanks for the feedback, I'll tweak my editor to do 2 tab instead of 4 tab. I'll also go ahead and change the author name to contain a link to their github.

McCune1224 commented 1 year ago

Alrighty, made the changes requested:

1.Javascript/HTML:

McCune1224 commented 1 year ago

For the CSS on hover the text will be dimmed:

Non-Hovered

Deck Created non-hover

Hovered (link displayed in bottom left)

Deck Created hover

N-Shar-ma commented 1 year ago

@McCune1224 Looks like you may have forgotten to push? 😅

Seeing the screenshots, could you make the link have an underline on hover instead of darkening it? Also please make it the same red like the rest of the text and not the default blue.

And in case you haven't already please remove the redundant position: absolute from the CSS

McCune1224 commented 1 year ago

Oops, yeah that would help to push it... Anywho made the additional CSS request to maintain the red and only underline on hover, here's what it looks like now

non-hover

Deck Created non-hover

hover

Deck Created hover

N-Shar-ma commented 1 year ago

Merged after a couple minor fixes. Thanks a lot @McCune1224 ! 🚀