N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
19 stars 26 forks source link

Deck Idea : Harry Potter #28

Closed Ni-vik closed 1 year ago

Ni-vik commented 1 year ago

I would like to create a deck of Harry Potter characters.

N-Shar-ma commented 1 year ago

@Ni-vik Sounds like a great idea! Please go through the newly added instructions here to add a new deck :)

PS: you can edit this very issue to add the content needed following the instructions!

Ni-vik commented 1 year ago

Here are some of the examples { name: "George Weasley", content: { primary: "🦁", secondary: " ❌👂", }, hint: "Saint-Like", matchValue: "identical twin brother of Fred Weasley", seenHint: false, }, { name: "Severus Snape", content: { primary: "🩸", secondary: "🐍🦌", }, hint: "Always", matchValue: "member of both the Death Eaters and the Order of the Phoenix", seenHint: false, }, { name: "Hermoine Granger", content: { primary: "📚", secondary: "🦁🐱", }, hint: "Muggle-born student in Harry's year", matchValue: "Prefect and co-founder of Dumbledore's Army", seenHint: false, } I am thinking of having at least one emoji referencing to the house of the character. And other emojis referencing to some of the memorable things. However I am concerned about matchValue being long in some cases. I am not able to come up to one pattern in matchValue.If anyone has any suggestions please share. If you think it fits the project I'll start working on it.

N-Shar-ma commented 1 year ago

@Ni-vik this looks really promising, please go ahead and make the PR! The matchValue can be any fact about the character that applies to that character uniquely (the examples look fine in that regard)

Any issues with matchValues being too long can be resolved quickly and easily once the PR is made, I'm pretty sure