search

N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
19 stars 26 forks source link

Famous Companies deck #34

Closed Girlwithasmile closed 1 year ago

Girlwithasmile commented 1 year ago

Fixes: #21

Girlwithasmile commented 1 year ago

Please can u provide me with a feedback..

N-Shar-ma commented 1 year ago

@Girlwithasmile Sorry for the delayed response. The deck is actually quite fun, but 2 major issues are preventing it from being merged. 1st, this information is something that is ever changing so this deck will very soon be outdated - which is why I would have liked you to wait for the issue to be approved by me and then assigned to you. 2nd, there are some hints only Hindi speakers will understand, like for Chanel, which we should avoid to make this accessible to more people across the globe.

A couple of minor problems are that the matchValues are a little too long, and that you forgot to add the deck to index.html

For resolving the 1st issue, you could change the deck to companies instead of CEOs. I believe the other issues are fairly easily solvable. Would be great if you could fix it up, though it would definitely take some rework. Do let me know what you plan to do with this PR next!

Girlwithasmile commented 1 year ago

Shall I convert it to founders to prevent problem of ever changing? And change the problematic clues??

N-Shar-ma commented 1 year ago

@Girlwithasmile Sounds good! Looking forward to the changes :)

N-Shar-ma commented 1 year ago

@Girlwithasmile This is almost ready to merge! 🎉 Could you please explain the emoji sequence for Chanel though? Especially the 2nd emoji?

Girlwithasmile commented 1 year ago

Chanel : Its a TV. The emoji is symbolic to remote through which we change channels. And the last is a nail.

N-Shar-ma commented 1 year ago

Thanks for contributing this deck @Girlwithasmile ! 🎉