N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
19 stars 26 forks source link

Add a toggle button that will switch between light and dark mode #38

Open RhyshaKachari opened 1 year ago

RhyshaKachari commented 1 year ago

To make the game's UI more appealing to the eyes , I think adding dark mode would be a great idea. If this sounds good to you too , I would like to work on this. Kindly assign me this issue :)

N-Shar-ma commented 1 year ago

Seems like a good idea @RhyshaKachari ! Would be great to 1st discuss and finalize the alternative dark color palette here, before making a PR

Utsab5 commented 1 year ago

Hi @N-Shar-ma , i would like to work on this issue. I am thinking of using the following colors: 1)dark blue ( preferably #041c32) 2)dark bluish green ( preferably #04293a) 3)dark navy blue ( preferably #064663) 4)yellow ( preferably #ecb365 or #ffa500)

N-Shar-ma commented 1 year ago

@Utsab5 That does seem like a nice alternate theme! However to be fair since @RhyshaKachari created the issue, I'll wait a day for her to propose colors too, then assign this to whoever's palette I prefer. Thanks for your interest!

PS: screenshots with the actual colors would have been nice, in addition to the hex codes 😅

Utsab5 commented 1 year ago

Sure @N-Shar-ma , It's fine with me, I'll wait for your next instructions.

Here is a screenshot of my selected palette's actual colors 👇🏻 photo_2022-10-06_19-20-31

RhyshaKachari commented 1 year ago

@N-Shar-ma this is the color palette I have decided for the dark theme

Color Hunt Palette 2a09443b185fa12568fec260

N-Shar-ma commented 1 year ago

@Utsab5 That palette looks nice! Please go ahead and make a PR

Utsab5 commented 1 year ago

Hi @N-Shar-ma , Can you please tell me why you are not merging my PR? Is there any issue in that ?

N-Shar-ma commented 1 year ago

@Utsab5 A little busy these days so am only going through simpler smaller PRs right now. I should have time to have a proper look later in the weekend.

Utsab5 commented 1 year ago

Okay

Utsab5 commented 1 year ago

Hi @N-Shar-ma , i have made the changes. Please have a look PS: Sorry for my late response due to exams.